You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Willing to take criticism on this method of doing it-- you could probably get close by taking advantage of the generic definition of remake in DiffEqBase, but AFAIK you'd have to remove the defined constructor for NoiseProcess and expose the original constructor, which could break a lot of downstream stuff for a tiny tweak. I felt more comfortable adding a few specific, but extensible utilities prescribed for the NoiseProcess type. If you disagree or find this dubious, feel free to close without merging.
Question? Is remake assume to keep the same field types and just change the values or does it (in general) allow changing the type as well?
Nevermind. I just checked that remake for an ODEProblem allows changing the type of fields. But the implemented copy, and any sound implementation of similar keeps the type. So, if we want to allow changing the type, we would need to implement remake directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow the user to
remakea NoiseProcess.